[Windows] Fix Border corners clipping issue by jsuarezruiz · Pull Request #14403 · dotnet/maui

jsuarezruiz · 2023-04-05T08:42:29Z

Description of Change

Fix Border corners clipping mistake on Windows. Checking x I realized that the changes applied in #10964 in Android and iOS were not in Windows.

We was clipping using the Border shape. That is correct in many cases but not always. Using a RoundRectangle, the Corner Radius value is not the same in the inner or outer. We want in this case user the inner value.

Before

Notice the internal white space between the content and the border.

After

Fix #9129

# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch.

jsuarezruiz · 2023-05-03T12:01:13Z

@hartez Could I have your feedback here?. Thanks!

rmarinho · 2023-06-19T13:35:51Z

+			UpdateClip(borderShape);
+		}
+
+		internal void UpdateBorderStroke(IBorderStroke borderStroke)


I think this can be public on net8 no @hartez ? or else the Obsolete comment will not make sense since this is internal users can't call it

rmarinho

I was testing the gallery and seems some calculations are still wrong when we have content inside, we can see this using the gallery

-Go to the Border Playground

Set Border Shape as Rectangle
Set a solid Border
Increase the Border Width to around 15
You can see the text gets clipped

here's how it looks on Android, seems ok:

jsuarezruiz · 2023-07-03T12:20:30Z

I was testing the gallery and seems some calculations are still wrong when we have content inside, we can see this using the gallery

-Go to the Border Playground

Set Border Shape as Rectangle

Set a solid Border

Increase the Border Width to around 15

You can see the text gets clipped

here's how it looks on Android, seems ok:

Reviewed and you are right. Without this PR changes can still reproduce it, so you have found a different issue. Will try to solve the issue in this same PR, and if require a bug amount of changes will open a new issue with a different associated PR.

jsuarezruiz · 2023-07-13T10:46:23Z

Applied changes to fix the issue detected by Rui:

jsuarezruiz · 2023-07-13T10:46:57Z

Added device tests:

stall

* [create-pull-request] automated change (#16413) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Windows] Fix Border corners clipping issue (#14403) * Fix Border corners clipping mistake on Windows * Updated impl * Created method to avoid duplicated code * Revert uneccesary changes * Changes in clipping sizing * Fix Rui issue * Added device tests * Remove unnecessary changes --------- Co-authored-by: Javier Suárez <6755973+jsuarezruiz@users.noreply.github.com> * Add ViewHandler Mapper docs (#16296) Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com> * [create-pull-request] automated change (#16427) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix device tests to tun on arm64 (#16408) * Build on arm64 * magic * Only install on Arm64 machines * cleanup demands on the pipeline and add windows parameter * Print system arch * Fix getting OSArchitecture --------- Co-authored-by: Rui Marinho <me@ruimarinho.net> * [uitests] Fix appium script (#16451) * Bump node version * Add more info to install script * Try clean modules before install * Uninstall before install * fix * Cleanup yaml * Write output of drivers * Try remove plugins before uninstall * [iOS] Fix Editor placeholder issues (#15883) * Fix iOS Editor placeholder size, characterspacing and fontsize issues * Added Device Test * Invalidate CharacterSpacing updating the placeholder * Updated Impl * [Essentials] Make PublisherName public on NET8 (#16454) * Fix EntryCellRenderer to use fromhandler for text changes (#16458) * [compatibility] Skip test on iOS (#16452) * [iOS] Re-enable editor tests (#16365) * Re-enable editor tests on iOS * Fix merge problem * [build] Remove the old step for vs insertion on release (#16457) * Reinstate IContentView and ILayout methods (#16411) * Reinstate IContentView and ILayout methods Fixes #16166 * Limit fake methods to NET Standard 2.0 * Reverse the polarity * Simplify * Work around compatibility implementations of ICV/ICPL methods on ScrollView * Use correct interface for Frame * [net8.0] Don't move to use arm yet here * [net8.0] Make UpdateBackground public (#16453) * [api] Make UpdateBackground public * Keep extensions internal * Fix issue setting ContentPage gradient background on iOS/Catalyst (#15832) * Fix provisioning script * [provisioning] Set Xcode path correctly for Xamarin Hosting --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Javier Suárez <6755973+jsuarezruiz@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com>

Fix Border corners clipping mistake on Windows

bda11df

jsuarezruiz added t/bug Something isn't working area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing area-controls-border Border labels Apr 5, 2023

ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Apr 5, 2023

mandel-macaque approved these changes Apr 5, 2023

View reviewed changes

jsuarezruiz requested a review from hartez April 10, 2023 15:15

jsuarezruiz added 6 commits April 10, 2023 17:17

Merge branch 'main' into housekeeping-border-corners

fccccd2

Merge branch 'main' into housekeeping-border-corners

0726a3d

Merge branch 'main' into fix-10407

341b69b

# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch.

Merge branch 'main' into housekeeping-border-corners

f531dac

Merge branch 'main' into housekeeping-border-corners

7934531

Merge branch 'main' into housekeeping-border-corners

ca2180e

Merge branch 'main' into housekeeping-border-corners

521ad3b

hartez previously requested changes May 10, 2023

View reviewed changes

Comment thread src/Core/src/Platform/Windows/ContentPanel.cs Outdated

jsuarezruiz added 2 commits May 31, 2023 10:24

Merge branch 'main' into housekeeping-border-corners

9a975ea

Updated impl

d61d149

jsuarezruiz requested a review from hartez May 31, 2023 08:58

jsuarezruiz added 2 commits June 6, 2023 14:31

Merge branch 'main' into housekeeping-border-corners

62013e5

Merge branch 'main' into housekeeping-border-corners

5c3fc09

rmarinho requested changes Jun 19, 2023

View reviewed changes

jsuarezruiz added 3 commits June 22, 2023 09:39

Merge branch 'main' into housekeeping-border-corners

cc1e9ee

Created method to avoid duplicated code

7110f6a

Revert uneccesary changes

1a93828

jsuarezruiz requested a review from rmarinho June 22, 2023 08:22

rmarinho requested changes Jun 22, 2023

View reviewed changes

jsuarezruiz marked this pull request as draft June 27, 2023 15:03

Merge branch 'main' into housekeeping-border-corners

9c73f9f

jsuarezruiz added 2 commits July 13, 2023 11:08

Changes in clipping sizing

30d99e7

Fix Rui issue

7b5ba62

jsuarezruiz requested a review from rmarinho July 13, 2023 10:40

jsuarezruiz added 2 commits July 13, 2023 12:47

Added device tests

6af3205

Remove unnecessary changes

b0b5c1c

jsuarezruiz mentioned this pull request Jul 13, 2023

Use correct clip path method for RoundRectangle #16132

Closed

Merge branch 'main' into housekeeping-border-corners

10cfdeb

jsuarezruiz marked this pull request as ready for review July 18, 2023 09:35

Merge branch 'main' into housekeeping-border-corners

08e88ae

jsuarezruiz mentioned this pull request Jul 19, 2023

Clipping an Image with a Border has a gap on Windows #9129

Closed

Merge branch 'main' into housekeeping-border-corners

a49adcd

samhouts added this to the .NET 8 GA milestone Jul 26, 2023

rmarinho approved these changes Jul 28, 2023

View reviewed changes

rmarinho merged commit 12c39bb into main Jul 28, 2023

rmarinho deleted the housekeeping-border-corners branch July 28, 2023 23:22

github-actions Bot locked and limited conversation to collaborators Dec 12, 2023

samhouts added the platform/windows label Feb 1, 2024

Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024

samhouts added the fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 label Aug 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Windows] Fix Border corners clipping issue#14403

[Windows] Fix Border corners clipping issue#14403
rmarinho merged 23 commits into
mainfrom
housekeeping-border-corners

jsuarezruiz commented Apr 5, 2023 •

edited

Loading

Uh oh!

jsuarezruiz commented May 3, 2023

Uh oh!

Uh oh!

Uh oh!

rmarinho Jun 19, 2023

Uh oh!

Uh oh!

rmarinho left a comment

Uh oh!

jsuarezruiz commented Jul 3, 2023

Uh oh!

jsuarezruiz commented Jul 13, 2023

Uh oh!

jsuarezruiz commented Jul 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

jsuarezruiz commented Apr 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Uh oh!

jsuarezruiz commented May 3, 2023

Uh oh!

Uh oh!

Uh oh!

rmarinho Jun 19, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rmarinho left a comment

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Jul 3, 2023

Uh oh!

jsuarezruiz commented Jul 13, 2023

Uh oh!

jsuarezruiz commented Jul 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jsuarezruiz commented Apr 5, 2023 •

edited

Loading